implement ephemeral port reservation for k3d #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/p/port-reservation
branch
2 times, most recently
from
c639d66
to
8e942a3
Compare
Prior to this commit we discovered that CI can flake when standing up multiple k3d clusters due to port conflicts. This commit attempts to implement "port reservation" such that pkg/k3d can always create k3d clusters without conflicts without coordination across different processes. It's unclear if this will actually work as engineering an intentional failure is not feasible.
RafalKorepta
force-pushed
the
chris/p/port-reservation
branch
from
8e942a3
to
e870e14
Compare
RafalKorepta
approved these changes
Nov 15, 2024
|
So, fun story with this. I can't actually prove/showcase that this will work. The implementation on linux may be different from macos/darwin/bsd but: When testing on macos, it seems that port conflicts do still get generated after running this test with I've not been able to track down any information about how ephemeral port assignment works in macos. It seems that ports in TIME_WAIT will be left alone until ephemeral ports near exhaustion. After which they get reassigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit we discovered that CI can flake when standing up multiple k3d clusters due to port conflicts.
This commit attempts to implement "port reservation" such that pkg/k3d can always create k3d clusters without conflicts without coordination across different processes.
It's unclear if this will actually work as engineering an intentional failure is not feasible.